Skip to content

fix: capture re-usable workflows as actions instead of scripts#1374

Merged
Ron (rjaegers) merged 10 commits into
mainfrom
fix/package-scripts-as-actions
Jul 22, 2026
Merged

fix: capture re-usable workflows as actions instead of scripts#1374
Ron (rjaegers) merged 10 commits into
mainfrom
fix/package-scripts-as-actions

Conversation

@rjaegers

@rjaegers Ron (rjaegers) commented Jul 21, 2026

Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request refactors the implementation of two utility scripts—generate-tool-inventory.sh and merge-devcontainer-metadata.sh—by replacing them with reusable GitHub composite actions. The workflows are updated to use these actions, which improves maintainability and reusability.
Key changes:

Workflow Refactoring and Actionization

  • Replaces the shell script generate-tool-inventory.sh with a composite action .github/actions/generate-tool-inventory/action.yml, and updates workflows to use this action for generating tool inventories from SBOMs. [1] [2] [3]
  • Replaces the shell script merge-devcontainer-metadata.sh with a composite action .github/actions/merge-devcontainer-metadata/action.yml, and updates workflows to use this action for merging devcontainer metadata. [1] [2] [3]

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM
  • I understand the image size delta and agree the functionality justifies it

Copilot AI review requested due to automatic review settings July 21, 2026 11:31
@rjaegers
Ron (rjaegers) requested a review from a team as a code owner July 21, 2026 11:31
Comment thread .github/workflows/wc-build-push.yml Fixed
Comment thread .github/workflows/wc-build-push.yml Fixed
Comment thread .github/workflows/wc-build-push.yml Fixed
Comment thread .github/workflows/wc-build-push.yml Fixed
Comment thread .github/workflows/wc-build-push.yml Fixed
@rjaegers Ron (rjaegers) changed the title Fix/package scripts as actions fix: capture re-usable workflows as actions instead of scripts Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 23 0 0 0.24s
✅ DOCKERFILE hadolint 4 0 0 0.27s
✅ JSON npm-package-json-lint yes no no 0.54s
✅ JSON prettier 44 6 0 0 0.93s
✅ JSON v8r 44 0 0 16.87s
✅ MARKDOWN markdownlint 13 0 0 0 1.34s
✅ MARKDOWN markdown-table-formatter 13 0 0 0 0.29s
✅ REPOSITORY betterleaks yes no no 1.19s
✅ REPOSITORY checkov yes no no 30.39s
✅ REPOSITORY gitleaks yes no no 1.3s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 70.94s
⚠️ REPOSITORY osv-scanner yes 1 no 0.82s
✅ REPOSITORY secretlint yes no no 2.3s
✅ REPOSITORY syft yes no no 2.68s
✅ REPOSITORY trivy yes no no 14.91s
✅ REPOSITORY trivy-sbom yes no no 0.4s
✅ REPOSITORY trufflehog yes no no 6.8s
⚠️ SPELL lychee 115 1 0 37.23s
✅ YAML prettier 35 0 0 0 1.41s
✅ YAML v8r 35 0 0 16.26s
✅ YAML yamllint 35 0 0 1.65s

Detailed Issues

⚠️ SPELL / lychee - 1 error
📝 Summary
---------------------
🔍 Total..........154
🔗 Unique.........126
✅ Successful.....148
⏳ Timeouts.........0
🔀 Redirected......19
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads (at 38:7) | Rejected status code: 403 Forbidden

Hint: Followed 19 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ REPOSITORY / osv-scanner - 1 error
Scanning dir .
Starting filesystem walk for root: /
Scanned .devcontainer/cpp/requirements.txt file and found 20 packages
Scanned .devcontainer/docs/requirements.txt file and found 14 packages
Scanned test/embedded-rust/workspace/cortex-m/Cargo.lock file and found 20 packages
Scanned test/embedded-rust/workspace/cortex-mf/Cargo.lock file and found 20 packages
Scanned test/rust/workspace/cargo/Cargo.lock file and found 1 package
Scanned test/rust/workspace/clippy/Cargo.lock file and found 1 package
Scanned test/rust/workspace/test/Cargo.lock file and found 1 package
Scanned package-lock.json file and found 73 packages
End status: 105 dirs visited, 339 inodes visited, 8 Extract calls, 34.575321ms elapsed, 34.575551ms wall time

Total 2 packages affected by 2 known vulnerabilities (0 Critical, 0 High, 0 Medium, 0 Low, 2 Unknown) from 1 ecosystem.
0 vulnerabilities can be fixed.

+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+
| OSV URL                           | CVSS | ECOSYSTEM | PACKAGE    | VERSION | FIXED VERSION | SOURCE                                            |
+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+
| https://osv.dev/RUSTSEC-2026-0110 |      | crates.io | bare-metal | 0.2.5   | --            | test/embedded-rust/workspace/cortex-m/Cargo.lock  |
| https://osv.dev/RUSTSEC-2026-0110 |      | crates.io | bare-metal | 0.2.5   | --            | test/embedded-rust/workspace/cortex-mf/Cargo.lock |
+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors two repository utility scripts into reusable GitHub composite actions and updates workflows to consume them, aiming to improve reuse and maintainability of the CI/build logic. It also includes a few security-hardening tweaks (e.g., --ignore-scripts for npm installs and --https-only for downloads).

Changes:

  • Replace .github/scripts/{generate-tool-inventory,merge-devcontainer-metadata}.sh with composite actions under .github/actions/.
  • Update wc-build-push.yml to use the new actions and harden the diffoci download with checksum verification.
  • Harden npm installs in CI and tighten some Dockerfile download/quoting patterns.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/wc-build-push.yml Switches metadata/tool-inventory generation to composite actions; updates diffoci download + checksum.
.github/workflows/wc-acceptance-test.yml Uses npm ci --ignore-scripts before Playwright install.
.github/scripts/merge-devcontainer-metadata.sh Removed (replaced by composite action).
.github/scripts/generate-tool-inventory.sh Removed (replaced by composite action).
.github/actions/merge-devcontainer-metadata/action.yml New composite action implementing devcontainer.metadata label merge logic.
.github/actions/generate-tool-inventory/action.yml New composite action generating tool inventory from SBOM + allowlist.
.github/actions/container-size-diff/action.yml Hardens npm install by adding --ignore-scripts.
.devcontainer/rust/Dockerfile Improves quoting and tightens wget HTTPS behavior.
.devcontainer/cpp/Dockerfile Tightens wget HTTPS behavior and adds safer quoting for args/paths.

Comment thread .github/workflows/wc-build-push.yml Outdated
Comment thread .github/workflows/wc-build-push.yml Outdated
Comment thread .github/actions/generate-tool-inventory/action.yml
Comment thread .github/workflows/wc-build-push.yml Dismissed
Comment thread .github/workflows/wc-build-push.yml Dismissed
Comment thread .github/workflows/wc-build-push.yml Dismissed
Comment thread .github/workflows/wc-build-push.yml Dismissed
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1374

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 75.35 MB 75.35 MB +19 B (+0%) 🔼
linux/arm64 73.43 MB 73.43 MB 131 B (0%) 🔽

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-docs:edgeghcr.io/philips-software/amp-devcontainer-docs:pr-1374

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 200.14 MB 200.14 MB 102 B (0%) 🔽
linux/arm64 196.35 MB 196.35 MB +110 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1374

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 406.07 MB 406.07 MB 191 B (0%) 🔽
linux/arm64 357.66 MB 357.66 MB 33 B (0%) 🔽

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-rust:edgeghcr.io/philips-software/amp-devcontainer-embedded-rust:pr-1374

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 468.96 MB 468.96 MB +127 B (+0%) 🔼
linux/arm64 419.92 MB 419.92 MB 90 B (0%) 🔽

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1374

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 372.13 MB 372.13 MB 56 B (0%) 🔽
linux/arm64 352.26 MB 352.26 MB 9 B (0%) 🔽

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 21, 2026 11:47 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-cpp:edgeghcr.io/philips-software/amp-devcontainer-embedded-cpp:pr-1374

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 560.5 MB 560.5 MB 1.55 kB (0%) 🔽
linux/arm64 538.95 MB 538.95 MB 1.72 kB (0%) 🔽

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 21, 2026 12:07 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Test Results

 25 files  ±0   25 suites  ±0   19m 53s ⏱️ + 2m 15s
 48 tests ±0   48 ✅ ±0  0 💤 ±0  0 ❌ ±0 
201 runs  ±0  201 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 713b05a. ± Comparison against base commit 4e14e99.

♻️ This comment has been updated with latest results.

Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Comment thread .devcontainer/cpp/Dockerfile Outdated
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 21, 2026 17:48 — with GitHub Actions Inactive
@rjaegers
Ron (rjaegers) added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit 3c233cd Jul 22, 2026
91 checks passed
@rjaegers
Ron (rjaegers) deleted the fix/package-scripts-as-actions branch July 22, 2026 07:19
@github-actions

Copy link
Copy Markdown
Contributor

Pull Request Report (#1374)

Static measures

Description Value
Number of added lines 164
Number of deleted lines 146
Number of changed files 5
Number of commits 10
Number of reviews 6
Number of comments (w/o review comments) 9
Number of reviews that contains a comment to resolve 5
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 7

Time related measures

Description Value
PR lead time (from creation to close of PR) 19.8 Hours
Time that was spend on the branch before the PR was created 2 Hours
Time that was spend on the branch before the PR was merged 21.8 Hours
Time to merge after last review 13.7 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 1.7 Hours
Total time spend in last status check run on PR 22.9 Min

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v8.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants